GH-36674: [C++] Use anonymous namespace in arrow/ipc/reader.cc #36937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
trying to fix #36674 |
|
hi, @westonpace , Would you like to review this PR when anytime you are available? Regards, |
pitrou
requested changes
Aug 9, 2023
|
@pegasas Can you make the PR description a bit more explicit? |
github-actions
bot
added
awaiting committer review
Sure. I added more description into that. |
pitrou
approved these changes
Aug 9, 2023
pitrou
changed the title
pitrou
changed the title
|
|
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 1a00fec. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…pache#36937) ### Rationale for this change The following types and functions should be in file scope: IpcReadConext, BatchDataReadRequest, ArrayLoader, DecompressBuffer(s), LoadRecordBatch*, GetCompression*, ReadRecordBatchInternal, GetInclusionMaskAndOutSchmea, UnpackSchemaMessage, ReadDictionary, AsyncRecordBatchStreamReaderImpl. ### What changes are included in this PR? Use anonymous namespace around the aforementioned definitions. ### Are these changes tested? No ### Are there any user-facing changes? No Lead-authored-by: pegasas <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The following types and functions should be in file scope:
IpcReadConext, BatchDataReadRequest, ArrayLoader,
DecompressBuffer(s), LoadRecordBatch*, GetCompression*,
ReadRecordBatchInternal,
GetInclusionMaskAndOutSchmea, UnpackSchemaMessage,
ReadDictionary, AsyncRecordBatchStreamReaderImpl.
What changes are included in this PR?
Use anonymous namespace around the aforementioned definitions.
Are these changes tested?
No
Are there any user-facing changes?
No